D29544: [applets/systemtray] Show base icon when AttentionIcon not set

[Konrad Materka]

kmaterka created this revision.
kmaterka added reviewers: Plasma: Workspaces, Plasma, ngraham, broulik, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kmaterka requested review of this revision.

REVISION SUMMARY
  If status is set to NeedsAttention it tries to use Attention Icon. If Attention Icon is not set, empty/null QIcon is set. QML can't check if QIcon is null or not, as a result it tries to use empty icon and nothing is rendered.
  Set null QVariant if AttentionIcon is not valid so that QML check will work correctly.

TEST PLAN
  - Set NeedsAttention as a status and with no Attention Icon
  - Base Icon should render correctly

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29544

AFFECTED FILES
  applets/systemtray/systemtraymodel.cpp

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200508/0d926434/attachment-0001.htm>