D29535: Change panel thickness adjustment UI to use a SpinBox

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: abetts, VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  We receive many complaints and bug reports about the current UI for adjusting panel
  thickness. People don't figure out that they have to drag on the button, and when they do,
  they complain that they can't set the value finely enough. Furthermore there are some bugs
  with scrolling and dragging behavior.
  
  This patch removes the draggable button and replaces it with a more conventional SpinBox,
  this is given scroll-adjustment behaviors in D29534 <https://phabricator.kde.org/D29534>. This yields the following
  improvements:
  
  - The way you adjust panel thickness is now more obvious
  - Fine-tuning panel thickness is now easier
  - Panel thickness can now be specified numerically
  - We have one fewer custom control to maintain
  - Bugs in custom scrolling implementation go away
  
  The current click/touch-and-drag behavior is therefore removed. I think this is acceptable
  because it's not a very good match for this use case anyway; a drag-based UI favors large
  changes where precision of the final result is not important. This does not describe the
  panel adjustment use case where you are changing the value by at most a few dozen and very
  commonly just want to adjust it up or down a tiny amount or want to end up at a specific
  size.
  
  BUG: 414045
  BUG: 418700
  BUG: 421169
  FIXED-IN: 5.19

TEST PLAN
  F8300568: Horizontal panel.webm <https://phabricator.kde.org/F8300568>
  F8300567: Vertical panel.webm <https://phabricator.kde.org/F8300567>

REPOSITORY
  R119 Plasma Desktop

BRANCH
  panel-adjustment-adjustment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29535

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml
  desktoppackage/contents/configuration/panelconfiguration/ToolBar.qml

To: ngraham, abetts, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200508/4d68ae44/attachment.htm>