D28154: Add users KCM

David Edmundson noreply at phabricator.kde.org
Thu May 7 15:51:34 BST 2020


davidedmundson added inline comments.

INLINE COMMENTS

> cblack wrote in kcm.cpp:97
> taking the initials of a user's real name

OH!

Initial-ise

not initialise as in "to prepare"

Makes sense :)

> usermodel.cpp:37
> +    connect(m_dbusInterface, &OrgFreedesktopAccountsInterface::UserAdded, this, [this](const QDBusObjectPath &path) {
> +        User *user = new User();
> +        user->setPath(path);

This one isn't parented to the model

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200507/e58f721d/attachment.htm>


More information about the Plasma-devel mailing list