D28154: Add users KCM

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ChangePassword.qml:24
> +import QtQuick.Layouts 1.3
> +import QtQuick.Controls 2.5
> +

...`as QQC2`

> CreateUser.qml:24
> +import QtQuick.Layouts 1.3
> +import QtQuick.Controls 2.5
> +

...`as QQC2`

> UserDetailsPage.qml:25
> +import QtGraphicalEffects 1.12
> +import QtQuick.Controls 2.5
> +import QtQuick.Dialogs 1.3

...`as QQC2`

> UserDetailsPage.qml:188
> +
> +                Menu {
> +                    id: deleteMenu

This menu doesn't close when you click outside of it; you need to hit the escape key.

> UserDetailsPage.qml:190
> +                    id: deleteMenu
> +                    MenuItem {
> +                        text: i18n("Delete files")

Give it an icon: `edit-delete`

> UserDetailsPage.qml:198
> +                    }
> +                    MenuItem {
> +                        text: i18n("Keep files")

Give it an icon: `document-multiple`

> UserDetailsPage.qml:208
> +                text: i18n("Delete User...")
> +                icon.name: "delete"
> +                onClicked: deleteMenu.open()

`edit-delete`

> main.qml:135
> +        QQC2.Button {
> +            Layout.alignment: Qt.AlignLeft
> +

Because the layout has a fillWidth item to the right, this isn't needed

> ngraham wrote in main.qml:96
> "kule"?

That was not a request for explanation but rather a gentle way of saying "please change this to something descriptive to a person who does not speak Toki Pona" :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200506/7a766289/attachment.html>