D29476: WIP: Port klipper to use wayland clipboard

[Aleix Pol Gonzalez]

apol added a comment.


  +1

INLINE COMMENTS

> systemclipboard.cpp:63
> +
> +class DataControlDeviceManager : public QWaylandClientExtensionTemplate<DataControlDeviceManager>
> +        , public QtWayland::zwlr_data_control_manager_v1

Maybe split the DataControl classes into a separate file?

> systemclipboard.h:45
> +
> +class XClipboard : public SystemClipboard
> +{

I'd call it QtClipboard or GenericClipboard. There's nothing X-specific there.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29476

To: davidedmundson, #kwin
Cc: apol, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200506/341a3d2f/attachment.html>