D29464: [applets/appmenu] Hide old menu before showing new menu

[Carson Black]

cblack created this revision.
cblack added reviewers: Plasma, KWin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  Hiding the old menu after the new menu is shown isn't possible on Wayland:
  
    qt.qpa.wayland: setGrabPopup called with a parent, QtWaylandClient::QWaylandXdgSurface(0x17dd550) which does not match the current topmost grabbing popup, QtWaylandClient::QWaylandXdgSurface(0x120d9f0) According to the xdg-shell protocol, this is not allowed. The wayland QPA plugin is currently handling it by setting the parent to the topmost grabbing popup. Note, however, that this may cause positioning errors and popups closing unxpectedly because xdg-shell mandate that child popups close before parents

TEST PLAN
  Before, Wayland: Trying to open a menu under Wayland while one is already open fails.
  After, Wayland: Trying to open a menu under Wayland while one is already open succeeds.
  Ensure no regressions on X11.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  cblack/appmenu-menu-fix-wayland (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29464

AFFECTED FILES
  applets/appmenu/lib/appmenuapplet.cpp

To: cblack, #plasma, #kwin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200505/ebaf937e/attachment.html>