D28154: Add users KCM

Nathaniel Graham noreply at phabricator.kde.org
Tue May 5 20:33:58 BST 2020


ngraham added a comment.


  I found a few more little things:
  
  1. This is not a big deal, but could the grid of avatars be horizontally centered in its sheet? F8287538: Screenshot_20200505_132938.png <https://phabricator.kde.org/F8287538>
  
  2. Text and icons in the Change Password sheet are clipped and pixellated for some reason: F8287541: Screenshot_20200505_133127.png <https://phabricator.kde.org/F8287541> However if I click in one of the password fields, the issue resolves itself!

INLINE COMMENTS

> UserDetailsPage.qml:239
> +                            Label {
> +                                text: i18n("Open File")
> +

I think "Choose from File..." would be more appropriate (and don't forget the ellipses, since it opens a file dialog)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200505/cc26ca02/attachment.html>


More information about the Plasma-devel mailing list