D28141: Add KSysGuard::Sensors library

[Nathaniel Graham]

ngraham added a comment.


  +1, excellent work.

INLINE COMMENTS

> Sensor.cpp:2
> +/*
> +    Copyright (C) 2019 Vlad Zagorodniy <vladzzag at gmail.com>
> +    Copyright (C) 2020 Arjen Hiemstra <ahiemstra at heimr.nl>

Update name

> Sensor.cpp:219
> +
> +    if(parent() && parent()->metaObject()->indexOfSignal("enabledChanged()") != -1) {
> +        connect(parent(), SIGNAL(enabledChanged()), this, SIGNAL(enabledChanged()));

`if (`

> SensorInfo_p.h:36
> +    SensorInfo() = default;
> +    QString name; //translated?
> +    QString shortName; // translated

Is it? :)

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D28141

To: ahiemstra, #plasma
Cc: ngraham, mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200504/22e1faf9/attachment.html>