D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

[Konrad Materka]

kmaterka added a comment.


  In D29344#662586 <https://phabricator.kde.org/D29344#662586>, @ngraham wrote:
  
  > 5.19 hasn't branched yet, so code landed in master will still make it there.
  
  
  Maybe there was code freeze for frameworks? Or 5.18.5? Never mind :)
  
  > With this patch, I still see Media Player itself with a blank icon after opening Gwenview. Is that expected?
  
  This is a separate issue... :/ I will work on that and create separate fix.

INLINE COMMENTS

> ngraham wrote in ItemLoader.qml:33
> "Illegal" is one of those scary words we try not to use, even in console spew. Consider changing this to "Invalid."
> 
> F8282506: Screenshot_20200503_214934.png <https://phabricator.kde.org/F8282506>

Old habits from Java world (IllegalStateException), I will change that.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29344

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, apol, davidedmundson
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200504/6b7f60bc/attachment-0001.html>