D29080: [kcms/fonts] Guide users towards KScreen KCM for making things bigger on-screen

[Kai Uwe Broulik]

broulik added a comment.


  Very lovely idea!

INLINE COMMENTS

> main.qml:36
>  
> +    property var kscreenAction: Kirigami.Action {
> +        visible: KCMShell.authorize("kcm_kscreen.desktop").length > 0

Why this as a `property`, not just an `Action` with an `id`?

> main.qml:70
> +                        || toolbarFontWidget.font.pointSize > 14
> +                        || menuFontWidget.font.pointSize > 18) {
> +                        hugeFontsMessage.visible = true

Why 18 here?

> main.qml:71
> +                        || menuFontWidget.font.pointSize > 18) {
> +                        hugeFontsMessage.visible = true
> +                    } else {

You could also just bind `visible` to the boolean expression in the if:

  hugeFontsMessage.visible = foo || bar || baz || bla

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29080

To: ngraham, #vdg, #plasma, cblack, bport
Cc: broulik, romangg, ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200502/6f384882/attachment.html>