D29234: Fix various bugs introduced with heading

[Niccolò Venerandi]

niccolove added a comment.


  I used the Svg instead of the plasmoidHeading to avoid using a Control. User-wise, it works correctly, but can I get your opinion code-wise?

INLINE COMMENTS

> broulik wrote in FullRepresentation.qml:454
> Move the `Svg` somewhere outside the delegate, I don't want multiple instances of it

I'm a bit confused here. The PlasmaCore.svg{id: lineSvg...} element was inside a different PlasmaCore.SvgItem that I removed. So what I did was essentially to move it from that SvgItem to this SvgItem. That one is the only instance of PlasmaCore.Svg.

> broulik wrote in NotificationItem.qml:125
> hm, ok

I moved it in a RowLayout to remove the necessity of checking altogether (otherwise, I should've put anchors.margins AND layout.margins for each case and it would've have been quite ugly imo)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29234

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200502/2ffac68b/attachment.html>