D29340: fix(kcm): avoid recursive OpacityMask which leads to teardown crash

Roman Gilg noreply at phabricator.kde.org
Fri May 1 16:36:50 BST 2020


romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  > Docs explicitly say this.
  
  When you reference some "docs" please take 20 seconds and directly link it. Every piece you write here and in git commit messages is potentially read by hundreds of other people. If you link the source once you save dozens of man-hours of other people looking the information up afterwards. Or they might decide to not look it up because it's too much hassle -> onboarding.
  
  Thanks for looking into that issue. lgtm without further delay, I trust you on your QML expertise.

INLINE COMMENTS

> Output.qml:60
> -    color: palette.window
> -    smooth: true
>  

Is the change making this unnecessary? I.e. do the graphics still look "smooth"?

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29340

To: davidedmundson, romangg
Cc: romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200501/27326bae/attachment.html>


More information about the Plasma-devel mailing list