D29319: KCM Plasmasearch: Do not intialize runners in config module

Alexander Lohnau noreply at phabricator.kde.org
Fri May 1 07:37:01 BST 2020


alex created this revision.
alex added reviewers: Plasma, davidedmundson, ngraham, meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  The runners are loaded from the plugin info list `Plasma::RunnerManager::listRunnerInfo()`,
  because of that there is no need to create a RunnerManager and initialize the plugins.
  
  If you have a lot of additional plugins installed that do a lot of work in the init/reloadConfiguration
  method the loading time of the KCM is notable slower.
  
  Additionally the KCMUTILS_VERSION version check has been removed, because
  the KF5_MIN_VERSION is 5.69.

TEST PLAN
  All plugin should show up.
  To check this create a debug which prints the length of the `listRunnerInfo` list.
  Then you can verify that the length of the list is equal to the count
  of entries in the plugin selector. For this you can also use the xdotool utility:
  `sleep 5;for i in {1..myNum};  do sleep 0.1;xdotool key Down; done`.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  do_not_initialize_runners (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29319

AFFECTED FILES
  kcms/runners/kcm.cpp
  kcms/runners/kcm.h

To: alex, #plasma, davidedmundson, ngraham, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200501/de661c0a/attachment-0001.html>


More information about the Plasma-devel mailing list