D28208: Move sni icon handling logic from data engine to applet

Konrad Materka noreply at phabricator.kde.org
Tue Mar 31 13:47:57 BST 2020


kmaterka added a comment.


  In D28208#638846 <https://phabricator.kde.org/D28208#638846>, @davidre wrote:
  
  > Yes it's not pretty but I had no other Idea. One option would be trying to manually search for the icon in the path?
  
  
  Not a good idea, theme path only point to root of more complex structure like `hicolor/22x22/apps/...`. This is also code/logic duplication.
  
  > Or if all else fails for now use the old icon property in case `IconThemePath` is set.
  
  As a temporary workaround - yes. Final goal is to add custom icon loader support to PlasmaCore.IconItem. I checked code, I see great potential for additional refactoring there :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28208

To: davidre, kmaterka, broulik, mart, #plasma, #vdg
Cc: bruns, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200331/d2b11c73/attachment.html>


More information about the Plasma-devel mailing list