D28455: add dbus interface to the greeter

[Bhushan Shah]

bshah added inline comments.

INLINE COMMENTS

> davidedmundson wrote in greeterapp.cpp:497
> This pattern of fetching and poking the root object of a scene isn't one I like, it's better to expose an object to the view that then has normal signals and slots - but this does follow the convention already here, so I can't really object.

Let's add a todo for future? Once this is done, I do have plan to change the OSD bit to also use greeter directly, instead of wayland protocol bit. That time I can update that.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D28455

To: bshah
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200331/8e98783d/attachment.html>