D28454: [libnotificationmanager] forward notifications to lockscreen greeter

[Bhushan Shah]

bshah added inline comments.

INLINE COMMENTS

> davidedmundson wrote in server_p.cpp:234
> "This" will lack any context when someone is actually debugging this.

"This" debug statement should be removed :P

> davidedmundson wrote in server_p.cpp:245
> I assume you forgot to have an
> 
> iface.Close(...)
> 
> line somewhere here

Yes, I haven't got full functionality working yet, this was more of RFC.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28454

To: bshah, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200331/e62d8f83/attachment.html>