D28454: [libnotificationmanager] forward notifications to lockscreen greeter

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Seems pretty simple and sensible.
  
  1 minor fixup needed.

INLINE COMMENTS

> server_p.cpp:234
> +            hints, notification.timeout());
> +        qCDebug(NOTIFICATIONMANAGER) << "This notification should be shown on lockscreen";
> +    }

"This" will lack any context when someone is actually debugging this.

> server_p.cpp:245
> +    // just ignore it.
> +    OrgKdeScreensaverGreeterInterface iface(QStringLiteral("org.kde.screensaver.Greeter"),
> +                                            QStringLiteral("/Greeter"), QDBusConnection::sessionBus());

I assume you forgot to have an

iface.Close(...)

line somewhere here

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28454

To: bshah, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200331/eb76261d/attachment-0001.html>