D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

[David Edmundson]

davidedmundson added a comment.


  > @davidedmundson - is QIcon(QImage(...)) save?
  
  For the way it's used in the runner, yes.
  
  > Before this patch the icon was created in the BookmarkMatch::asQueryMatch method which was called from the secondary thread.
  
  Then my comment is happily refuted. I read the title and wanted to provide context for why it might have been like that making an assumption.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28439

To: alex, apol, broulik, davidedmundson
Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200331/99b99483/attachment.html>