D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

[Alexander Lohnau]

alex created this revision.
alex added reviewers: apol, broulik, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  Before: A pointer to the favicon gets written in the BookmarkMatch and using this pointer the icon gets created when the Plasma::QueryMatch gets created.
  Now: Using the favicon pointer the icon gets created and written to the BookmarkMatch, when the QueryMatch is created the icon value is read.
  
  This makes the code easier to unserstand and the BookmarkMatch is independent of the Favicon class.
  
  Depends on D28196 <https://phabricator.kde.org/D28196>, because this bugfix is needed for my config.

TEST PLAN
  Should compile and display icons.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  bookmarks_change_icon_handling_in_matches

REVISION DETAIL
  https://phabricator.kde.org/D28439

AFFECTED FILES
  runners/bookmarks/bookmarkmatch.cpp
  runners/bookmarks/bookmarkmatch.h
  runners/bookmarks/browsers/chrome.cpp
  runners/bookmarks/browsers/firefox.cpp
  runners/bookmarks/browsers/kdebrowser.cpp
  runners/bookmarks/browsers/opera.cpp

To: alex, apol, broulik, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200330/7306cdc9/attachment.html>