D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

[Benjamin Port]

bport added a comment.


  Some coding style nitpicking

INLINE COMMENTS

> export_scheme_dialog.cpp:46
>      int item=0;
> -    Q_FOREACH(QString component, mComponents)
> +    for (const QString &component : qAsConst(mComponents))
>      {

{ on same line

> export_scheme_dialog.cpp:74
> +    const auto buttons = mButtons.buttons();
> +    for (const QAbstractButton *button : buttons)
>      {

{ on same line

> kglobalshortcutseditor.cpp:168
>  
> -        for( KServiceGroup::List::ConstIterator it = list.constBegin();
> +        for ( KServiceGroup::List::ConstIterator it = list.constBegin();
>               it != list.constEnd(); ++it) {

you have an unneeded space after (

> kglobalshortcutseditor.cpp:543
> +        for (const QString &group : groupList)
>              {
>              // do not overwrite the Settings group. That makes it possible to

{ on same line

> kglobalshortcutseditor.cpp:832
> +    for (const QString &text : keys)
>          {
>          if (components.value(text)->uniqueName() == componentUnique)

{ same line

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28282

To: meven, ervin, bport, crossi, hchain, #plasma
Cc: ahmadsamir, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200330/16fa5788/attachment.html>