Monday Meeting Notes Week 14 (2020-03-30)

[Kai Uwe Broulik]

Week 14 of 2020 Plasma meeting notes from 2020-03-30:
Hope you're all doing well and staying at home.

DavidRedondo
============
* I am continuing work for coloring icons in the correct colors
	* Patch for breeze kdecoration now up on phab: 
https://phabricator.kde.org/D28330
	* IconItem is fixed already
* Somebody reported to me a bug in the systray because they thought it 
was also coloring bug
	* Turns out our sni implementation was bad
	* The data engine does complicated icon logic which breaks and has 
weird interaction with plasma iconitem
* Patch on phab to expose only the raw properties in the engine and do 
the rendering in the actual implementation 
https://phabricator.kde.org/D28208

Q/A:

<d_ed> dataengines are supposedly stable API
<kbroulik> d_ed: yeah that was my main concern also but I think we all 
involved agreed it was an acceptable break for the common good™
<DavidRedondo> Yeah that's why I didn't actually remove the properties 
for now
<d_ed> ok, cool
<DavidRedondo> So we could keep them around if we want to
<DavidRedondo> And just ignore them in the applet
<d_ed> nah, I'm fine with killing all dataengines with fire :)
<d_ed> as long as we're aware of everything
<DavidRedondo> We asked latte if they use it and they just use the 
systray applet

d_ed
====
* I've been working on two big things
* plasma getting a systemd powered startup
	* This is most going all well, all the long groundwork moving 
plasma-session meant it's all gone pretty smoothly
* Also I've been doing some big changes to ksysguard
	* last year we introduced plugins for processes, which worked quite well
	* so I've done the same for the global stats
	* with a new API and all
	* these are some big reviews, so we need some volunteers on that
* In terms of my usual frustrated rant:
	* This bug list of "very high priority bugs"
	https://bugs.kde.org/buglist.cgi?cmdtype=dorem&list_id=1729437&namedcmd=VHI-priority%20Plasma%20bugs&remaction=run&sharer_id=208174
	* seems to not have moved at all
	* like last week
* we had a "security" ish, issue last week with .desktop files having an 
Exec line being used in KRun(someUrl)
	* whilst we're doing the Application/Command job porting and looking 
through usages of KRun it's worth checking any that use the 
KRun(someUrl) constructor and possibly making them not execute things
* my other thing I wanted to discuss - if lots of people are on Corona 
lockdown it might be a good opportunity for some onboarding
	* so I was thinking we could organise some "bug day" or day-long 
virtual sprint or something...

Q/A:

<DavidRedondo> I think the breeze gtk thing is moving
<kbroulik> I've got stuck on the pinned apps moving
<kbroulik> I'm pretty sure I know what's going on and what's causing it, 
fixing it is annoying
<d_ed> ok, that's good to hear
<d_ed> make sure to keep bugs up to date with findings
<kbroulik> I wonder if Bug 418466 is also a side-effect of that ghns 
changedentrieschanged emissions bug
<sKreamer> KDE bug 418466 in systemsettings (kcm_desktoptheme) "Intalled 
Global themes not showing up in Setting's Global theme section." 
[normal,] https://bugs.kde.org/show_bug.cgi?id=418466
<d_ed> I hereby task you with finding out !
<kbroulik> ok
[...]
<DavidRedondo> d_ed: but that's the same with clicking on said file right
<kbroulik> DavidRedondo: when clicking on it in dolphin it asks
<kbroulik> recent docs runner would just blatantly execute
<d_ed> KRun(someUrl) also asks
<d_ed> if not executable
<kbroulik> also, if possible use service explicitly with URL
<d_ed> yeah, that too
<kbroulik> e.g. that's what I added KServiceAction for 
applicationlauncherjob, so we don't exec a command but invoke the 
"proper service"
<d_ed> DavidRedondo: so you're right it wasn't super critical or easy to 
exploit, but it's still worth locking down what we can
[...]
<DavidRedondo> Speaking of corona, because of sprints being canceled I 
had the idea maybe we could arange topic calls or something if needed?
<d_ed> DavidRedondo: ack. I think we need a wayland call at some point 
after that long ML thread
<bshah> Virtual sprint? :D

bshah
=====
* I have been mostly busy with:
	* "[libnotificationmanager] forward notifications to lockscreen" [Needs 
Review] https://phabricator.kde.org/D28427
	* Diff 28428 "[screenlocker] listen to notifications from the 
notification server" [Needs Review] https://phabricator.kde.org/D28428
	* There's some more code but it is not polished enough to be public :P
	* Apart from it my last week hasn't been that much productive.

Q/A:

<d_ed> is that stuck on anything needing discussion?
<bshah> d_ed: nope, not really
<ahiemstra[m]> how generic is that?
<ahiemstra[m]> as in, would it also support displaying notifications on 
the normal lockscreen?
<kbroulik> not very iirc
<kbroulik> we've discussed making it generic but we kinda coujldn't 
agree on a scope and security model
<bshah> ahiemstra[m]: it could, yes. But I am test-driving it on mobile 
greeter first
<ahiemstra[m]> right
<bshah> then someone can add it in desktop greeter ;)
<ahiemstra[m]> sure
<bshah> there's bit we (I and Kai) discussed about notification handler
<bshah> which is kinda neat, but then we didn't find a right place to 
put this as API
<bshah> and then my nice plan was killed :'(
<kbroulik> yeah I would have loved a generic notification proxy thing 
also for kde connect
<kbroulik> but whenever we started discussing it, the scope went out of 
hand and then it ended up nowhere for being too large
<kbroulik> so I'd say we focus on this specific thing first, make it 
good, and then see what we need in the future
<bshah> (I still have some notes about handler stuff locally, I can 
potentially start discussion on p-d)
<ahiemstra[m]> TODO: far in the future ;)
<kbroulik> bshah: yes, please do
<kbroulik> also make sure to include kdeconnect in the mix :)

ahiemstra
=========

* I finished up the shadowedtexture last week, that's ready to be landed
	* Diff 28222 "Add ShadowedImage and ShadowedTexture items" [Accepted] 
https://phabricator.kde.org/D28222
* I also did a follow up to have separate corner radii
	* Diff 28314 "Allow setting separate corner radii for 
ShadowedRectangle" [Needs Review] https://phabricator.kde.org/D28314
* I've done some small updates on the ksysguard library work that 
supports d_ed's daemon
* last thing I wanted to mention is that I'm looking into
	* https://bugreports.qt.io/browse/QTBUG-49646 "Kerning incorrect in 
some applications"

notmart
=======

# Kirigami:
* fixed a freeze while flicking on mobile
* finished overlaysheet refactor

# Plasma Bigscreen:
* last fixes for the beta
* beta released!
* wrote a couple of blog posts about it (second i'll publish today) 
https://notmart.org/blog/2020/03/plasma-bigscreen
* started making mycroft fully optional
let's see if i'll be able of doing some more plasma-plasma things now

Q/A:

<kbroulik> I've did an experiment of using that color detector thing 
from bigscreen to colorize my task bar entries by app icon
<kbroulik> it sounded nicer in my head than it now actually looks :)
<notmart> eh, it's the typical cool thing that has to be used very with care
<kbroulik> yeah
<veggero> That's interesting though, maybe it could be worth a VDG 
discussion
<notmart> with great power comes great current squared times resistance
<kbroulik> veggero: I just did a crappy "colorize the svg thing". I 
recall icontasks in kde4 had a nice glow and stuff where the color 
looked really nice
<kbroulik> maybe works better for icontasks.. anyway i'd love that color 
detector somewhere in a usable lib :P
<notmart> i wouldn't like a clone of the windows7 taskbar look with that 
silly colorized gradient on mouse over
<ahiemstra[m]> what they do in win10 is even worse, it's basically that 
effect but only on an outline

fvogt
=====

* would only ask about the state of Qt 5.15 support anyway

Q/A:

<kbroulik> fvogt: what about it?
<kbroulik> apart from deprecation porting
<d_ed> fvogt: As I understand it everything is all ok
<d_ed> I should upgrade my laptop to latest Qt5.15 branch to be sure 
there's been nothing last minute
<fvogt> There were some reports about severe instability on bugzilla, 
but openQA couldn't confirm that

ismailof
========

* @kbroulik asked me to discuss a bit about the kwinrules  kcm?

Q/A:

<kbroulik> is there something you're stuck on with your rules kcm?
<d_ed> ismailof[m]: you've done a great job on that btw
<kbroulik> I've been poking some devs occasionally to keep the momentum 
going
<ismailof[m]> not really stuck, just being conservative about when "wip" 
ends :D
<d_ed> ismailof[m]: given it's an advanced user KCM, I think in terms of 
the UI/UX you're hitting diminishing returns with changes
<ahiemstra[m]> yeah it's really cool
<kbroulik> just be mindful of the 5.19 freezes early may
<kbroulik> so perhaps merge soon-ish and then clean it up until the beta? :)
<kbroulik> I just want to avoid someone going a day before the Beta "oh 
this is so cool, can we have this in" so i'd rather merge sooner than later
<ismailof[m]> alright! I'll take today for some polishing maybe, and set 
it ready for review

kbroulik
========

# Notifications:
* Continued discussion about inline-reply spec on XDG...
* Added `KNotificationJobUiDelegate`, please review: D28295
	* Diff 28295 "Introduce KNotificationJobUiDelegate" [Needs Review] 
https://phabricator.kde.org/D28295
	* Allows to use KNotification for job error reporting rather than a 
modal message box
	* Useful for the new `ApplicationLauncherJob` replacement for `KRun` so 
apps launched from Plasma use a nice Plasma error notification

# plasma-firewall:
* Made `KSortFilterProxyModel` `invalidateFilter` public
	* Eases creation of QML-only custom view filtering
* Fixed size propagation bug in `FormLayout`
	* Did you know QtQml `Timer` default `interval` is 1000? :)
* Some minor UI improvements

# Other:
* Fixed virtual desktop pager not updating rows when only rows changed 
but not the number of desktops
* Made a bodge fix for wallpaper thumbnails not loading: D28420
	* Diff 28420 "[Image Wallpaper] Fix thumbnail generation when model is 
reloaded in-flight" [Needs Review] https://phabricator.kde.org/D28420
	* Caused by GHNS Button signalling a change when there isn't. See 
commit description in the phab for what's going on
* Added support for launching `KServiceActions` in `ApplicationLauncherJob`
	* This will give us a proper API for launching jump list actions rather 
than just running the action `Exec` as command
	* Patch for Task Manager D28286 and services/shell runner D28347
	* Diff 28286 "[Task Manager] Port backend to ApplicationLauncherJob" 
[Needs Review] https://phabricator.kde.org/D28286
	* Diff 28347 "Port services and shell runner away from KRun" [Needs 
Review] https://phabricator.kde.org/D28347

-------------- next part --------------
A non-text attachment was scrubbed...
Name: plasmanotes2020-03-20.log
Type: text/x-log
Size: 16081 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200330/259cf1aa/attachment.bin>