D26934: KCM/Autostart Add a model to separate logic from UI

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> meven wrote in autostart.cpp:210
> ?

rows inserted gives you a range of [first,last] which was added

> meven wrote in autostart.cpp:182
> You mean I should use open/finished right ?

Yes.
It then also needs to set a transient parent and window modality manual I think

> meven wrote in autostart.cpp:241
> Can't use it here: QTreeWidgetItem does not inherit QObject.

Ok

> meven wrote in autostartmodel.h:52
> Not sure what you mean.

Why define `DisplayRole` as dedicated enum entry, rather than just using `Qt::DisplayRole` in the code everywhere

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26934

To: meven, mlaurent, ervin, #plasma, broulik, bport, crossi
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200330/d3c97c9a/attachment-0001.html>