D28208: Move sni icon handling logic from data engine to applet

[David Redondo]

davidre added a comment.




INLINE COMMENTS

> systemtraymodel.cpp:331
> +    if (!iconThemePath.isEmpty()) {
> +         loader = new KIconLoader(sourceName, {iconThemePath});
> +         loader->addAppDir(sourceName, iconThemePath);

This works now, but I don't know how to manage the KIconLoader. The KIconEngines are managed by QIcon (they take ownership of the engine). One idea would be to add it to the item maybe?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28208

To: davidre, kmaterka, broulik, mart, #plasma, #vdg
Cc: bruns, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200330/506b6beb/attachment.html>