D28360: cmake: make xsettingsd check an option

Mikhail Zolotukhin noreply at phabricator.kde.org
Sun Mar 29 23:09:58 BST 2020


gikari added a comment.


  In D28360#636687 <https://phabricator.kde.org/D28360#636687>, @kossebau wrote:
  
  >   Edit: and yes, I agree CMake has awful flaws here when it comes to our needs to properly communicate dependencies to fellow developers & packagers. I am trying to give you best practices done so far elsewhere in KDE software to deal with this, to ensure consistent patterns in the approach to the same problem :)
  
  
  Did I understand correctly, that to make the dependency required for distribution packagers you need to substitute existing code with the following (i.e. only change the `PURPOSE` text, but keep `find_package` as it was):
  
    find_package(XSettingsd)
    set_package_properties(XSettingsd PROPERTIES
        DESCRIPTION "XSettingsd daemon"
        TYPE RUNTIME
        PURPOSE "Required to have GTK Config kded module to apply settings to GTK applications on the fly"
    )

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28360

To: eszlari, gikari
Cc: rikmills, kossebau, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200329/6ff1f159/attachment-0001.html>


More information about the Plasma-devel mailing list