D28389: Add support for logging categories

Aleix Pol Gonzalez noreply at phabricator.kde.org
Sun Mar 29 17:27:03 BST 2020


apol added a comment.


  Other than that, the patch looks good. +1

INLINE COMMENTS

> romangg wrote in CMakeLists.txt:23
> Any idea how to reuse the declaration from the top-directory CMake file?

Make sure the include() call is before the add_subdirectory().

That's why we usually put them together on top right under the find_package() together with `include(ECMGenerateHeaders)`.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D28389

To: romangg, #plasma
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200329/ef3525b2/attachment-0001.html>


More information about the Plasma-devel mailing list