D28286: [Task Manager] Port backend to ApplicationLauncherJob

Anthony Fieroni noreply at phabricator.kde.org
Sat Mar 28 10:14:48 GMT 2020


anthonyfieroni added inline comments.

INLINE COMMENTS

> backend.cpp:236-239
> +            auto *job = new KIO::ApplicationLauncherJob(service);
> +            auto *delegate = new KNotificationJobUiDelegate;
> +            delegate->setAutoErrorHandlingEnabled(true);
> +            job->setUiDelegate(delegate);

I see that redundant code in many places can you wrap it in function

  KJob* createApplicationNotificationLauncherJob

or something similar.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28286

To: broulik, #plasma, hein, dfaure
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200328/983b3724/attachment-0001.html>


More information about the Plasma-devel mailing list