D27914: [Kilpper] Port QRegExp to QRegularExpression

Ahmad Samir noreply at phabricator.kde.org
Sat Mar 28 07:36:26 GMT 2020


ahmadsamir added inline comments.

INLINE COMMENTS

> apol wrote in urlgrabber.h:185
> I think it's a silly way to do the port but okay, probably works and we get to move on.

What is silly about it?

The original code in ClipCommandProcess used:
const QStringList matches = action.regExpMatches();
which was:
QStringList regExpMatches() const { return m_myRegExp.capturedTexts(); }

REPOSITORY
  R120 Plasma Workspace

BRANCH
  l-klipper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27914

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200328/17c7e1c0/attachment-0001.html>


More information about the Plasma-devel mailing list