D28365: [krunner] Avoid (another) pointless config load on start

Aleix Pol Gonzalez noreply at phabricator.kde.org
Sat Mar 28 00:24:35 GMT 2020


apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> view.cpp:110
>      // Catch both, direct changes to the config file ...
> -    connect(KDirWatch::self(), &KDirWatch::dirty, this, &View::reloadConfig);
> -    connect(KDirWatch::self(), &KDirWatch::created, this, &View::reloadConfig);
> +    connect(KDirWatch::self(), &KDirWatch::dirty, this, [this]() {
> +            m_config.config()->reparseConfiguration();

Using 2 lambdas looks unnecessary, make a reparseConfig private slot?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28365

To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200328/72d69ce6/attachment.html>


More information about the Plasma-devel mailing list