D28369: [runners/recentdocuments] disable executables or .desktop files

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  It's possible to have a .desktop file in your recent documents list as
  you were editing it. Either as a .desktop file or masquerading as
  something else.
  
  By default we would process the .desktop file like a .desktop file.
  
  You do get a prompt if the .desktop file is not executable like in
  dolphin.
  
  Given we know from context that we're showing recent "Documents" we may
  as well turn that behaviour off without risk of ill effects.
  
  BUG: 419310

TEST PLAN
  Created .desktop file (masquerading as something else)
  Had it in my recent documents after opening in another format
  Loaded the file from krunner. It now opened in my text editor instead of running
  the Exec line

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28369

AFFECTED FILES
  runners/recentdocuments/recentdocuments.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200327/86df2340/attachment-0001.html>