D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting for wayland

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> main.qml:333
> +                    15,
> +                    20];
> +

nitpick: I'd put the closing square bracket on the next line and you can drop the semicolumn

> main.qml:343
> +                    value = index;
> +                }
> +

You can drop the semicolumn in there

> main.qml:346
> +                onMoved: {
> +                    device.scrollFactor = values[value];
> +                    root.changeSignal()

ditto

> touchpad.qml:631
> +                    15,
> +                    20];
> +

Same comment applies than for mouse

> touchpad.qml:638
> +                    if (index === -1) {
> +                        index = values.indexOf(1);
> +                    }

ditto

> touchpad.qml:644
> +                onMoved: {
> +                    touchpad.scrollFactor = values[value];
> +                    root.changeSignal()

ditto

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28331

To: meven, #kwin, #plasma, davidedmundson, ervin, bport, crossi, hchain
Cc: ngraham, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200327/32f2b794/attachment-0001.html>