D27914: [Kilpper] Port QRegExp to QRegularExpression

Ahmad Samir noreply at phabricator.kde.org
Fri Mar 27 17:19:18 GMT 2020


ahmadsamir added inline comments.

INLINE COMMENTS

> apol wrote in urlgrabber.h:185
> Then call it m_regularExpression?

Another point (which I forgot since it has been some time since I last looked at this patch), QRegExp stores the match info in itself, whereas QRegularExpression stores the match info in a QRegularExpressionMatch object (returned from calling QRegularExpression::match()), so if I use a m_regularExpression I'll have to add a getter for it, so that it can be called from URLGrabber::matchingActions().

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27914

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200327/027883af/attachment.html>


More information about the Plasma-devel mailing list