D28330: Color icons in titlebar if possible

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Fri Mar 27 15:09:46 GMT 2020


kossebau added inline comments.

INLINE COMMENTS

> breezebutton.cpp:148
> +            QPalette palette = decoration()->client().data()->palette();
> +            palette.setColor(QPalette::Foreground, qobject_cast<Decoration*>(decoration())->fontColor());
> +            KIconLoader::global()->setCustomPalette(palette);

Is there a chance the cast could fail?
Otherwise also use a static_cast, given you do not check the result, is faster (or is it a cross-cast?).

REPOSITORY
  R31 Breeze

BRANCH
  icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28330

To: davidre, #plasma, #vdg, ngraham
Cc: kossebau, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200327/84aecfa6/attachment.html>


More information about the Plasma-devel mailing list