D28129: Read the new message string after rather than before
Harald Sitter
noreply at phabricator.kde.org
Fri Mar 27 11:08:44 GMT 2020
sitter accepted this revision.
sitter added a comment.
Mind the comment about the +2 please.
Other than that looks reasonable.
INLINE COMMENTS
> backtraceparsergdb.cpp:215
> + case BacktraceLine::Info:
> + d->m_infoLines << line.toString().mid(KCRASH_INFO_MESSAGE.size() + 2);
> + break;
Please add a comment on what that +2 is, or better yet give it a var so it has an explicit name in code.
REPOSITORY
R871 DrKonqi
BRANCH
arcpatch-D28129
REVISION DETAIL
https://phabricator.kde.org/D28129
To: apol, #frameworks, broulik, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200327/f92a0821/attachment-0001.html>
More information about the Plasma-devel
mailing list