D28289: Refactor of OverlaySheet

[Marco Martin]

mart added a comment.


  In D28289#635232 <https://phabricator.kde.org/D28289#635232>, @ngraham wrote:
  
  > Generally much nicer looking. I found one visual issue: when I switch from touchpad scrolling to touchscreen scrolling, the close button in the corner gets overlapped by the content area since the scroll track gets narrower.
  
  
  in general the x button when there is not an header is giving some problems, uglyness and complications.
  I'm thinking to maybe *always* show the header with separator line and all even if empty when there is a close button...

INLINE COMMENTS

> ngraham wrote in OverlaySheet.qml:4
> Is this intentional?

ah, sorry no derives from conflicts resolution

> ngraham wrote in OverlaySheet.qml:278
> I thought we weren't supposed to multiply duration values. :) is the new `veryLongDuration` not long enough? do we need `superDuperLongDuration`?

was a debug thing forgotten in, sorry :)

> ngraham wrote in OverlaySheet.qml:363
> what's this `+1` for?

to make the view always scrolling, or the swipe to dismiss can get broken

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28289

To: mart, #kirigami
Cc: anthonyfieroni, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200327/1ca4819f/attachment.html>