D28321: [WIP] [applets/devicenotifier] Port to ExpandableListItem

Nathaniel Graham noreply at phabricator.kde.org
Thu Mar 26 21:21:36 GMT 2020


ngraham created this revision.
ngraham added reviewers: VDG, Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  WIP because of the TODOs at the top of the file in `DeviceItem.qml`. Assistance with
  these would be appreciated.

TEST PLAN
  The only major UI change is the loss of the progress bar. It is replaced with a textual
  display of free space and total space in the subtitle, which is more consistent with the
  appearance of other ExpandableListItem-using applets, and IMO is more useful anyway.
  
  F8200390: vokoscreenNG-2020-03-26_15-16-38.webm <https://phabricator.kde.org/F8200390>

REPOSITORY
  R120 Plasma Workspace

BRANCH
  port-to-ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28321

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/ActionItem.qml
  applets/devicenotifier/package/contents/ui/DeviceItem.qml
  applets/devicenotifier/package/contents/ui/FullRepresentation.qml
  applets/devicenotifier/package/contents/ui/devicenotifier.qml
  dataengines/soliddevice/soliddeviceengine.cpp

To: ngraham, #vdg, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200326/d8f3cd62/attachment.html>


More information about the Plasma-devel mailing list