D28318: [controls/formlayout] Don't attempt to reset implicitWidth

Carson Black noreply at phabricator.kde.org
Thu Mar 26 19:47:25 GMT 2020


cblack created this revision.
cblack added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  When a FormLayout is in wide mode, it attempts to
  reset the implicitWidth of a GridLayout by assigning undefined to it.
  This doesn't work because:
  
  1. Layouts provide their own implicit width
  2. You can't reset an implicit size with undefined, hence the error messages obtained from trying to do so

REPOSITORY
  R169 Kirigami

BRANCH
  cblack/formlayout-warnings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28318

AFFECTED FILES
  src/controls/FormLayout.qml

To: cblack, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200326/7df91044/attachment.html>


More information about the Plasma-devel mailing list