D27669: [kstyle] Tools area

Carson Black noreply at phabricator.kde.org
Thu Mar 26 16:37:33 GMT 2020


cblack added a comment.


  In D27669#635285 <https://phabricator.kde.org/D27669#635285>, @davidre wrote:
  
  > In D27669#635243 <https://phabricator.kde.org/D27669#635243>, @cblack wrote:
  >
  > > Assume there's no borders when there's not a BorderSize entry
  >
  >
  > That's totally not correct. The default value when there's no BorderSize entry is "Normal" . This patch is now also enabled when the user manually selects "Normal". The correct thing is to check  first whether `BorderSizeAuto` is enabled (default true) . If it's not enabled you can read `BorderSize` (default "Normal") otherwise check what the preference the decoration sets. I didn't check yet where that value is defined
  
  
  Took a look: it's not defined anywhere; it's up to the decorations to do whatever they feel like.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200326/99233afe/attachment-0001.html>


More information about the Plasma-devel mailing list