D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> globalshortcuts.cpp:42
>      editor = new KGlobalShortcutsEditor(this, KShortcutsEditor::GlobalAction);
> -    connect(editor, SIGNAL(changed(bool)), this, SIGNAL(changed(bool)));
> +    connect(editor, &KGlobalShortcutsEditor::changed, this, QOverload<bool>::of(&KCModule::changed));
>  

Use markAsChanged then you don't need to overload.

> kglobalshortcutseditor.h:84
>       */
> -    void exportConfiguration(QStringList componentsFriendly, KConfig *config) const;
> +    void exportConfiguration(const QStringList componentsFriendly, KConfig *config) const;
>  

why not const QStringList &

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28282

To: meven, ervin, bport, crossi, hchain, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200325/2028b04e/attachment.html>