D28272: Avoid copying buffer twice

Vlad Zahorodnii noreply at phabricator.kde.org
Wed Mar 25 13:32:51 GMT 2020


zzag added inline comments.

INLINE COMMENTS

> screencaststream.cpp:549-563
> +    // bind framebuffer to copy pixels from
> +    GLuint framebuffer;
> +    glGenFramebuffers(1, &framebuffer);
> +    glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
> +    glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 0);
> +    const GLenum status = glCheckFramebufferStatus(GL_FRAMEBUFFER);
> +    if (status != GL_FRAMEBUFFER_COMPLETE) {

Do we actually need an fbo?

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28272

To: jgrulich, #plasma
Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200325/2f4b3cb5/attachment-0001.html>


More information about the Plasma-devel mailing list