D28234: Use SyntaxHighlighter for highlighting

Harald Sitter noreply at phabricator.kde.org
Wed Mar 25 12:52:05 GMT 2020


sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  I love it!

INLINE COMMENTS

> backtracewidget.cpp:230
> +            m_highlighter = new KSyntaxHighlighting::SyntaxHighlighter(ui.m_backtraceEdit->document());
> +            m_highlighter->setTheme((palette().color(QPalette::Base).lightness() < 128)
> +                 ? repository.defaultTheme(KSyntaxHighlighting::Repository::DarkTheme)

Ugh that's awkward.

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28234

To: apol, #plasma, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200325/6f7f02b2/attachment.html>


More information about the Plasma-devel mailing list