D28276: only add devices to the smb mount model that are network shares
Harald Sitter
noreply at phabricator.kde.org
Wed Mar 25 11:15:33 GMT 2020
sitter created this revision.
sitter added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.
REVISION SUMMARY
previously we'd add all devices which would then cause a crash when
trying to access them ->as<NetworkShare>() because they aren't
TEST PLAN
have kcm open, plug in usb stick, observe no crash
REPOSITORY
R102 KInfoCenter
BRANCH
smb-type-check2
REVISION DETAIL
https://phabricator.kde.org/D28276
AFFECTED FILES
Modules/samba/smbmountmodel.cpp
To: sitter, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200325/80159b7b/attachment.html>
More information about the Plasma-devel
mailing list