D28208: Move sni icon handling logic from data engine to applet

[Konrad Materka]

kmaterka added a comment.


  > Some of the icons are not rendering now, for example:
  >  Discord - iconName: chrome_app_indicator2_83406baa15c6e4f2766a6e3714fbee20
  >  Skype1 - iconName: chrome_app_indicator2_01cdeaaa54803d9c9c158a5cdcb1fbfb
  >  I'm pretty sure I saw a workaround for that somewhere, but I can't recall where...
  
  Found it! You need to handle `IconThemePath`, which can be difficult... :/

INLINE COMMENTS

> StatusNotifierItem.qml:30
>      subText: model.ToolTipSubTitle
>      icon: model.ToolTipIcon !== "" ? model.ToolTipIcon : model.Icon ? model.Icon : model.IconName
>      textFormat: Text.AutoText

You need to change here as well.

> StatusNotifierItem.qml:61
> +    PlasmaCore.IconItem {
> +        id: overlayIconItem
> +        source: {

add `parent: iconItem.parent`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28208

To: davidre, kmaterka, broulik, mart, #plasma, #vdg
Cc: bruns, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200324/e0b394dd/attachment-0001.html>