D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

Alexander Lohnau noreply at phabricator.kde.org
Tue Mar 24 14:42:35 GMT 2020


alex added a comment.


  Small issue: Currently this patch can't be applied (from the master branch)  because in R114:47381a65debe01a0a015e1aa423cbb78af649648 <https://phabricator.kde.org/R114:47381a65debe01a0a015e1aa423cbb78af649648> the line:
  `QStringList terms = query.split(QLatin1Char(' '), QString::SkipEmptyParts);` got changed.
  I don't know how to resolve this conflict and would be thankful for help :-).

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27070

To: alex, #plasma, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200324/af59bf49/attachment.html>


More information about the Plasma-devel mailing list