D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Mar 24 08:03:11 GMT 2020


broulik accepted this revision.
broulik added inline comments.

INLINE COMMENTS

> webshortcutrunner.cpp:79
>      const int delimIndex = term.indexOf(m_delimiter);
> -    if (delimIndex == term.length() - 1)
> +    if (delimIndex == -1 || delimIndex == term.length() - 1){
>          return;

Coding style: put space before `{`

REPOSITORY
  R120 Plasma Workspace

BRANCH
  webshortcuts_cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27566

To: alex, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200324/e3f6ca87/attachment.html>


More information about the Plasma-devel mailing list