D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

[Stefan Brüns]

bruns marked 2 inline comments as done.
bruns added inline comments.

INLINE COMMENTS

> ngraham wrote in filteredfoldermodel.cpp:36
> this handy little function feels like it wants to be in KCoreAddons or something

Now its likely inlined by the compiler ...

> ngraham wrote in main.qml:112
> Since this is only used once, it could simply be declared inline
> 
>   delegate: Kirigami.SwipeListItem {
>       id: listItem
>       onClicked: {
>       [blabla]
>   }

IMHO it is to large to be declared inline. The toplevel layout is ~90 lines and can be viewed on a single screen now.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28025

To: bruns, #baloo, #vdg, ngraham, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200324/104b9a4f/attachment-0001.html>