D28208: Move sni icon handling logic from data engine to applet

Stefan BrĂ¼ns noreply at phabricator.kde.org
Mon Mar 23 23:26:10 GMT 2020


bruns added inline comments.

INLINE COMMENTS

> kmaterka wrote in StatusNotifierItem.qml:90
> Yes, you are correct, my mistake. So `StatusNotifierItemSource` has no margin and `KIconLoader` has 5% of icon size - another inconsistency.
> What about 'always round when multiplying by a non-integer value'? I don't know exactly why, but AFAIK not-rounded number can cause inconsistent behavior in QML.
> @ngraham can you give a word of explanation?

The `0.05 * iconSize` in KIconLoader has an implicit `math.floor` by the int conversion.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28208

To: davidre, kmaterka, broulik, mart, #plasma, #vdg
Cc: bruns, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200323/16dc18e7/attachment.html>


More information about the Plasma-devel mailing list