D28208: Move sni icon handling logic from data engine to applet

[David Redondo]

davidre marked 3 inline comments as done and an inline comment as not done.
davidre added inline comments.

INLINE COMMENTS

> StatusNotifierItem.qml:90
> +            bottom: iconItem.bottom
> +            bottomMargin: 0.05 * iconItem.width
> +            rightMargin: anchors.bottomMargin

Hmm to me it looks it doesn't even have an margin. Or am I reading   ` p.drawPixmap(QRect(m_iconPixmap.width()-size, m_iconPixmap.height()-size, size, size), overlay->pixmap(size, size), QRect(0,0,size,size));` wrong?

> systemtraymodel.h:97
>          IconThemePath,
>          IconsChanged,
>          Id,

I will do it in a seperate commit.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28208

To: davidre, kmaterka, broulik, mart, #plasma, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200323/0e8e8890/attachment.html>