D27098: Bugfix: Konsole does not launch, optimize and simplify runner

[Aleix Pol Gonzalez]

apol added a comment.


  If you ask me, this patch does many things:
  
  - fixes an issue
  - changes coding style
  - does some code bits a bit more differently.
  
  It's hard to review for me, I hope someone else more familiar with the codebase can.

INLINE COMMENTS

> konsoleprofiles.cpp:155
> -
> -                if (profileData.displayName.compare(term, Qt::CaseInsensitive) == 0) {
> -                    match.setRelevance(1.0);

Why has the relevance code been removed?

REPOSITORY
  R114 Plasma Addons

BRANCH
  konsole_bugfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27098

To: alex, davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200323/451c20c5/attachment-0001.html>