D28209: [applets/notes] Actually hide button row when it's not visible

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Currently the row's opacity is changed from 0% to 100% depending on focus state, but it
  does not actually become hidden when at 0% opacity. This means that it's possible to
  click the invisible buttons accidentally when focusing the applet. This has been an
  issue for a long time, but becomes dangerous with D28064 <https://phabricator.kde.org/D28064>, since you could delete a note just by clicking in the bottom-right corner to focus the applet!
  
  This patch makes the button row actually hidden when the applet is not focused, not just
  100% transparent.

TEST PLAN
  Clicking on the place where a button will appear on an unfocused applet now just focuses
  it and does not also click the button

REPOSITORY
  R114 Plasma Addons

BRANCH
  hide-row (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28209

AFFECTED FILES
  applets/notes/package/contents/ui/main.qml

To: ngraham, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200322/4d08803a/attachment-0001.html>