D28208: Move sni icon handling logic from data engine to applet

Nathaniel Graham noreply at phabricator.kde.org
Sun Mar 22 20:57:04 GMT 2020


ngraham added inline comments.

INLINE COMMENTS

> StatusNotifierItem.qml:84
> +            }
> +            return 64;
> +        }

Most of these numbers correspond to standard icon sizes (e.g. `units.iconSize.smallMedium` == 22); maybe use those where possible

> StatusNotifierItem.qml:90
> +            bottom: iconItem.bottom
> +            bottomMargin: 0.05 * iconItem.width
> +            rightMargin: anchors.bottomMargin

always round when multiplying by a non-integer value

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28208

To: davidre, kmaterka, broulik, mart, #plasma, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200322/d0483264/attachment.html>


More information about the Plasma-devel mailing list